build: fix inclusion of aw-cli command and click dep - #127
Merged
Merged
Conversation
The aw-cli entry point is part of the wheel, but is non-functional without the aw_cli package and the click dependency.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0a64f19 in 7 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pyproject.toml:33
- Draft comment:
Adding 'click' as a dependency is correct to ensure the functionality of the aw-cli command, as it is required for command-line interface operations. - Reason this comment was not posted:
Confidence changes required:0%
The addition of the 'click' dependency is necessary for the functionality of the aw-cli command, as described in the PR. This is a valid change.
Workflow ID: wflow_jvnjKYcYUuFfcZlX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Member
|
Oops, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aw-cli entry point is part of the wheel, but is non-functional without the aw_cli package and the click dependency.
Important
Fix
aw-clicommand by includingaw_clipackage and addingclickdependency inpyproject.toml.clickto[tool.poetry.dependencies]inpyproject.tomlto ensureaw-clicommand functionality.aw_cliin[tool.poetry.packages]inpyproject.tomlto make theaw-clientry point functional.This description was created by
for 0a64f19. It will automatically update as commits are pushed.