tag PR validation - #72
Open
jacopocinaark wants to merge 1 commit into
Open
jacopocinaark wants to merge 1 commit into
jacopocinaark wants to merge 1 commit into
Conversation
ref: AB#23224
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The critical tag-filter issue remains unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the GitHub Actions validation workflow to trigger on four-component version tags.
Changes:
- Adds a four-segment version-tag pattern to push triggers.
File summaries
| File | Review |
|---|---|
.github/workflows/python-tests.yml |
The added pattern is redundant because the existing glob already matches tags with additional dots; the tag filter requires correction. |
Review details
Suppressed comments (1)
.github/workflows/python-tests.yml:8
- This trigger also routes four-component numeric tags into
publish-stablebecause its condition only excludesaandb. That job callsvalidate_tag.sh ga, whose regex accepts onlyvX.Y.Z, and the build job's version extraction likewise falls back to0.0.0for this format, so every tag enabled here fails validation (or would publish the wrong version if validation were bypassed). Remove this pattern until the downstream tag validation and version parsing are updated consistently, or update those consumers in the same change.
- "v[0-9]*.[0-9]*.[0-9]*.[0-9]*"
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| branches: [master] | ||
| tags: | ||
| - "v[0-9]*.[0-9]*.[0-9]*" | ||
| - "v[0-9]*.[0-9]*.[0-9]*.[0-9]*" |
AndreaCuneo
requested changes
Sep 16, 2026
AndreaCuneo
left a comment
Contributor
There was a problem hiding this comment.
copilot review is right and the tag extension is not needed.
more importantly:
- the Task on the AB board is empty
- the Task doesn't explain the problem nor the PR description
- the Task is under a RESOLVED Requirement
this is sloppy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: AB#23224