Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

8258753: StartTlsResponse.close() hangs due to synchronization issues - #95

Closed
pkumaraswamy wants to merge 1 commit into
openjdk:masterfrom
pkumaraswamy:JDK-8258753
Closed

8258753: StartTlsResponse.close() hangs due to synchronization issues#95
pkumaraswamy wants to merge 1 commit into
openjdk:masterfrom
pkumaraswamy:JDK-8258753

Conversation

@pkumaraswamy

@pkumaraswamy pkumaraswamy commented Mar 29, 2021 •
edited by openjdk Bot
Loading

Copy link
Copy Markdown

This is a clean backport of JDK-8258753 (only copyright changes differ)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258753: StartTlsResponse.close() hangs due to synchronization issues ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/95/head:pull/95
$ git checkout pull/95

Update a local copy of the PR:
$ git checkout pull/95
$ git pull https://git.openjdk.java.net/jdk16u pull/95/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 95

View PR using the GUI difftool:
$ git pr show -t 95

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/95.diff

@bridgekeeper

bridgekeeper Bot commented Mar 29, 2021

Copy link
Copy Markdown

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@pkumaraswamy pkumaraswamy changed the title Backport 415553325831b79a7e55071f6bd7c73eb1a636ec 8258753: StartTlsResponse.close() hangs due to synchronization issues Mar 29, 2021
@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 29, 2021
@mlbridge

mlbridge Bot commented Mar 29, 2021

Copy link
Copy Markdown

Webrevs

coffeys
coffeys approved these changes Mar 29, 2021
View reviewed changes

@coffeys coffeys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@openjdk

openjdk Bot commented Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown

@pkumaraswamy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258753: StartTlsResponse.close() hangs due to synchronization issues

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Mar 29, 2021
@pkumaraswamy

pkumaraswamy commented Mar 30, 2021

Copy link
Copy Markdown
Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 30, 2021
@openjdk

openjdk Bot commented Mar 30, 2021

Copy link
Copy Markdown

@pkumaraswamy
Your change (at version e39bd31) is now ready to be sponsored by a Committer.

@coffeys

coffeys commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

/sponsor

@openjdk openjdk Bot closed this Mar 30, 2021
@openjdk openjdk Bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2021
@openjdk

openjdk Bot commented Mar 30, 2021

Copy link
Copy Markdown

@coffeys @pkumaraswamy Pushed as commit 484087b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@coffeys coffeys coffeys approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pkumaraswamy @coffeys