Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8258753: StartTlsResponse.close() hangs due to synchronization issues - #85

Closed
yan-too wants to merge 1 commit into
openjdk:masterfrom
yan-too:bp8258753
Closed

8258753: StartTlsResponse.close() hangs due to synchronization issues#85
yan-too wants to merge 1 commit into
openjdk:masterfrom
yan-too:bp8258753

Conversation

@yan-too

@yan-too yan-too commented Jul 30, 2021 •
edited by openjdk Bot
Loading

Copy link
Copy Markdown
Collaborator

I'd like to backport this fix here, too. The patch applies cleanly, tier tests run OK.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8258753: StartTlsResponse.close() hangs due to synchronization issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/85/head:pull/85
$ git checkout pull/85

Update a local copy of the PR:
$ git checkout pull/85
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/85/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 85

View PR using the GUI difftool:
$ git pr show -t 85

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/85.diff

@bridgekeeper

bridgekeeper Bot commented Jul 30, 2021

Copy link
Copy Markdown

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk Bot changed the title Backport 415553325831b79a7e55071f6bd7c73eb1a636ec 8258753: StartTlsResponse.close() hangs due to synchronization issues Jul 30, 2021
@openjdk

openjdk Bot commented Jul 30, 2021

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk

openjdk Bot commented Jul 30, 2021 •
edited
Loading

Copy link
Copy Markdown

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8258753: StartTlsResponse.close() hangs due to synchronization issues

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2021
@mlbridge

mlbridge Bot commented Jul 30, 2021

Copy link
Copy Markdown

Webrevs

@yan-too

yan-too commented Jul 30, 2021

Copy link
Copy Markdown
Collaborator Author

/integrate

@openjdk

openjdk Bot commented Jul 30, 2021

Copy link
Copy Markdown

Going to push as commit 028242b.

@openjdk openjdk Bot closed this Jul 30, 2021
@openjdk openjdk Bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2021
@openjdk

openjdk Bot commented Jul 30, 2021

Copy link
Copy Markdown

@yan-too Pushed as commit 028242b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too
yan-too deleted the bp8258753 branch July 30, 2021 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

backport clean integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yan-too