Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
/label add 2d |
|
@prrace |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@prrace Since your change was applied there have been 17 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 940b053. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
| @@ -58,7 +58,7 @@ | |||
|
|
|||
| #define GET_CPRINTERDIALOG_METHOD_RETURN(ret) \ | |||
There was a problem hiding this comment.
I guess the name of the macro should be renamed as well?
Didn't hit this because all the print testing I conducted used the swing print + page dialog but the logging made it easy to find the source of the problem.
I've also done an audit of GET_METHOD_* usages for this pattern - I had previously done it for DECLARE_METHOD* which is the bulk.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1952/head:pull/1952$ git checkout pull/1952