Closed
Bug 2047788
Opened 3 months ago
Closed 1 month ago
Show less/more transition animation
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
155 Branch
| Tracking | Status | |
|---|---|---|
| firefox155 | --- | fixed |
People
(Reporter: dgrant, Assigned: dgrant, NeedInfo)
References
Details
(Whiteboard: [hnt])
Attachments
(1 file)
No description provided.
Clicking show more/less previously snapped the widgets container to its new
height. Capture the pre-toggle height and FLIP-animate the container to its
new height using the same timing tokens widgets use when resizing, so the
row collapses and expands smoothly. Hidden widgets still use display:none so
tab order and a11y are unaffected. The animation is skipped under
prefers-reduced-motion.
|
||
Updated•2 months ago
|
Attachment #9597710 -
Attachment description: WIP: Bug 2047788 - Animate the widgets row height when toggling show more/less r?#home-newtab-reviewers → Bug 2047788 - Animate the widgets row height when toggling show more/less r?#home-newtab-reviewers
|
|
||
Updated•2 months ago
|
Attachment #9597710 -
Attachment description: Bug 2047788 - Animate the widgets row height when toggling show more/less r?#home-newtab-reviewers → WIP - Bug 2047788 - Animate the widgets row height when toggling show more/less r?#home-newtab-reviewers
|
|
||
Updated•2 months ago
|
Attachment #9597710 -
Attachment description: WIP - Bug 2047788 - Animate the widgets row height when toggling show more/less r?#home-newtab-reviewers → Bug 2047788 - Animate the widgets row height when toggling show more/less r?#home-newtab-reviewers
|
||
Updated•2 months ago
|
Pushed by dgrant@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c9480f67625a
https://hg.mozilla.org/integration/autoland/rev/eac7378493b3
Animate the widgets row height when toggling show more/less r=thecount
Pushed by csabou@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5f6d2d24a40b
https://hg.mozilla.org/integration/autoland/rev/f369f63080c7
Revert "Bug 2047788 - Animate the widgets row height when toggling show more/less r=thecount" for causing widgetsContainerRef eslint failures.
|
||
Comment 5•1 month ago
|
||
Backed out for causing widgetsContainerRef failures.
Failure logs:
- https://treeherder.mozilla.org/logviewer?job_id=579772219&repo=autoland&task=KFmvXkBcRAyvsXowr72KYg.1
- https://treeherder.mozilla.org/logviewer?job_id=579769979&repo=autoland&task=CQ7NvIKdQM2UcLsAHQ5qyQ.0
- https://treeherder.mozilla.org/logviewer?job_id=579769922&repo=autoland&task=AP3dC7N-R5SDDc5GBaQbYg.0
Flags: needinfo?(dgrant)
Pushed by dgrant@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/18e838c2e87f
https://hg.mozilla.org/integration/autoland/rev/ff019475bb4b
Animate the widgets row height when toggling show more/less r=thecount
Pushed by nfay@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/9700c29486c4
https://hg.mozilla.org/integration/autoland/rev/c24b728e6d0a
Revert "Bug 2047788 - Animate the widgets row height when toggling show more/less r=thecount" for causing lint failure @ Widgets.jsx
|
||
Comment 8•1 month ago
|
||
Pushed by dgrant@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/964bd2e9354a
https://hg.mozilla.org/integration/autoland/rev/08c4df942565
Animate the widgets row height when toggling show more/less r=thecount
|
||
Comment 10•1 month ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox155:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
|
||
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c156/b155]
You need to log in
before you can comment on or make changes to this bug.
Description
•