Closed Bug 2041335 Opened 3 months ago Closed 1 month ago

Stop using enterNestedEventLoop in webdriver bidi debugging module

Categories

(Remote Protocol :: WebDriver BiDi, task, P3)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task

Tracking

(firefox155 fixed)

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: jdescottes, Assigned: khalid.alhaddad98)

References

Details

(Whiteboard: [webdriver:m21][webdriver:external][webdriver:relnote])

Attachments

(1 file)

Bug 2041335 - Stop using enterNestedEventLoop in webdriver bidi debugging module. r=jdescottes
48 bytes, text/x-phabricator-request
Details | Review

See https://phabricator.services.mozilla.com/D288831?id=1263891#inline-1617357

At the moment the WebDriver BiDi debugging module uses the same API as devtools to enter a nested event loop enterNestedEventLoop. This might create conflicts with DevTools if used in parallel with BiDi.

Instead we can emulate a similar behavior via

this.#paused = true;
Services.tm.spinEventLoopUntil("webdriver-bidi-debugging", function () {
    return !this.#paused;
});
Priority: -- → P3
Whiteboard: [webdriver:backlog]
Assignee: nobody → khalid.alhaddad98
Depends on: 2060460
Pushed by jdescottes@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/02f01a7f8502 https://hg.mozilla.org/integration/autoland/rev/0cfc4705e5c6 Stop using enterNestedEventLoop in webdriver bidi debugging module. r=jdescottes

https://hg.mozilla.org/mozilla-central/rev/0cfc4705e5c6

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Whiteboard: [webdriver:backlog] → [webdriver:m21][webdriver:external]
Whiteboard: [webdriver:m21][webdriver:external] → [webdriver:m21][webdriver:external][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: