Closed Bug 2018709 Opened 6 months ago Closed 1 month ago

Migrate Base unit test to Jest/RTL

Categories

(Firefox :: New Tab Page, enhancement)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: maxx, Assigned: thecount)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 2018709 - Migrate Base unit test to Jest/RTL. r=#home-newtab-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Migrate the Base/BaseContent component tests, which test the top-level layout including prefs-driven conditional rendering, error state handling, and Redux store integration.

Updated tests:

  • test/unit/content-src/components/Base.test.jsx

Migrates Base.test.jsx from Enzyme/Karma to React Testing Library/Jest,
covering _Base, BaseContent, and WithDsAdmin.

  • Adds test/unit/jest/content-src/components/Base.test.jsx with 15 tests
  • Adds mocks to jest-setup.js: performance.getEntriesByType and
    ContentSearchHandoffUIController (Firefox browser globals)
  • Uses doNotFake: ["performance"] with jest.useFakeTimers to prevent
    @sinonjs/fake-timers from replacing the performance object
  • Marks test/unit/content-src/components/Base.test.jsx with
    @enzyme-to-rtl comment
Attachment #9547560 - Attachment is obsolete: true
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Attachment #9618905 - Attachment description: WIP: Bug 2018709 - Migrate Base unit test to Jest/RTL → WIP: Bug 2018709 - Migrate Base unit test to Jest/RTL. r?thecount
Attachment #9618905 - Attachment description: WIP: Bug 2018709 - Migrate Base unit test to Jest/RTL. r?thecount → WIP: Bug 2018709 - Migrate Base unit test to Jest/RTL. r=#home-newtab-reviewers
Attachment #9618905 - Attachment description: WIP: Bug 2018709 - Migrate Base unit test to Jest/RTL. r=#home-newtab-reviewers → Bug 2018709 - Migrate Base unit test to Jest/RTL. r=#home-newtab-reviewers

https://hg.mozilla.org/mozilla-central/rev/6cee3adbd43c

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Blocks: 2062310
No longer blocks: 2018692
Attachment #9618710 - Attachment is obsolete: true
QA Whiteboard: [qa-triage-done-c156/b155]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: